Add support for "to" prop as a function #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v12
approved these changes
Apr 24, 2017
Member
v12
left a comment
v12
left a comment
There was a problem hiding this comment.
LGTM as it's the same what RRv3 does.
Member
|
RRv4 doesn't natively support this syntax though? |
Author
|
No, it doesn't. In RR4 it can be achieved by wrapping Link component in Route component. |
Member
|
Does the same strategy work here? |
Author
|
Sorry, didn't quite understand. This PR is only for rr-v3 branch. I can make a separate PR to add support for this notation in master. |
Member
|
oops, misread |
Author
|
Would you mind cutting v23.3? |
Member
|
I can take a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.