Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow only second argument #972

Merged
merged 1 commit into from
Dec 6, 2024
Merged

allow only second argument #972

merged 1 commit into from
Dec 6, 2024

Conversation

cstadler333
Copy link
Contributor

Description

  • allow to omit first argument in favor of automatic "current location"
  • use api to allow origin and destination as separate optional arguments
  • reverse logic to use normal maps as fallback if no parameters are given

Type of change

  • Improvement of an existing script

Checklist

- allow to omit first argument in favor of automatic "current location"
- use api to allow origin and destination as separate optional arguments
Copy link
Contributor

@giedreblekaite giedreblekaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, works great!

Copy link
Collaborator

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cstadler333, thanks for your contribution to our repository!

It looks good to me!

@unnamedd unnamedd added the accepted PR is ready to be merged label Dec 6, 2024
@cstadler333
Copy link
Contributor Author

thanks! I'm glad to be able to help 😊

@giedreblekaite giedreblekaite merged commit 4b0811a into raycast:master Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants