Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazon-s3-download): handle file, folder and bucket downloads #963

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

zirkelc
Copy link
Contributor

@zirkelc zirkelc commented Sep 17, 2024

Description

This PR improves the amazon-s3-download script:

  • if the URL like s3://bucket/foo/bar/baz.json points to a file baz.json, it will download the file as Downloads/baz.json instead of creating the full directory structure Downloads/bucket/foo/bar/baz
  • if the URL like s3://bucket/foo/bar points to a folder bar, it will download the entire folder as Downloads/bucket/foo/bar/*
  • if the URL like s3://bucket includes no key, it will download the entire bucket as Downloads/bucket/*

Type of change

  • New script command
  • Bug fix
  • Improvement of an existing script
  • Documentation update
  • Toolkit change
  • Other (Specify)

Screenshot

File download:
https://github.com/user-attachments/assets/f7c1e337-f621-4259-9202-d3f89a4db126

Folder download:
https://github.com/user-attachments/assets/c7b98e56-abbf-43ca-a823-52e4a3cbf21d

Bucket download:
https://github.com/user-attachments/assets/037e3d86-ae98-496a-a965-7de5339551ee

Dependencies / Requirements

Checklist

@giedreblekaite giedreblekaite self-requested a review September 17, 2024 12:09
Copy link
Contributor

@giedreblekaite giedreblekaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clear PR and fixes!

@giedreblekaite giedreblekaite merged commit 9a03ab6 into raycast:master Sep 19, 2024
@zirkelc zirkelc deleted the fix-s3-download branch September 19, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants