Allow port nil #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bracket is missing in the previous refactor.
…in_table, ngx_http_lua_copy_str_in_table, ngx_http_lua_socket_udp_send, log_wrapper and ngx_http_lua_ngx_echo.
rainingmaster
force-pushed
the
allow_port_nil
branch
from
e9737df to
047e4a7
Compare
rainingmaster
pushed a commit
that referenced
this pull request
Apr 18, 2021
…found by coverity
deref_ptr: Directly dereferencing pointer c.
419 if (c->addr_text.len) {
420 p = ngx_snprintf(buf, len, ", client: %V", &c->addr_text);
421 len -= p - buf;
422 buf = p;
423 }
424
CID 149837 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking c suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
425 if (c && c->listening && c->listening->addr_text.len) {
426 p = ngx_snprintf(buf, len, ", server: %V", &c->listening->addr_text);
427 /* len -= p - buf; */
428 buf = p;
429 }
rainingmaster
pushed a commit
that referenced
this pull request
Apr 18, 2021
…esty#1846) 734 buf = p; 735 deref_ptr: Directly dereferencing pointer c. 736 if (c->addr_text.len) { 737 p = ngx_snprintf(buf, len, ", client: %V", &c->addr_text); 738 len -= p - buf; 739 buf = p; 740 } 741 CID 149839 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking c suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 742 if (c && c->listening && c->listening->addr_text.len) { 743 p = ngx_snprintf(buf, len, ", server: %V", &c->listening->addr_text); 744 /* len -= p - buf; */ 745 buf = p; 746 }
zhuizhuhaomeng
pushed a commit
that referenced
this pull request
Dec 26, 2021
==openresty==70603==ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges [0x621000001500,0x621000002181) and [0x62100000187f, 0x621000002500) overlap
#0 0x7f3db1899ffe (/lib64/libasan.so.5+0x99ffe)
#1 0x9da926 (/usr/local/openresty-debug/nginx/sbin/nginx+0x9da926)
#2 0x9dd1a1 (/usr/local/openresty-debug/nginx/sbin/nginx+0x9dd1a1)
#3 0x4c89c6 (/usr/local/openresty-debug/nginx/sbin/nginx+0x4c89c6)
openresty#4 0x5d1e4e (/usr/local/openresty-debug/nginx/sbin/nginx+0x5d1e4e)
openresty#5 0x4c89c6 (/usr/local/openresty-debug/nginx/sbin/nginx+0x4c89c6)
openresty#6 0x5b8583 (/usr/local/openresty-debug/nginx/sbin/nginx+0x5b8583)
openresty#7 0x4c89c6 (/usr/local/openresty-debug/nginx/sbin/nginx+0x4c89c6)
openresty#8 0x4b4419 (/usr/local/openresty-debug/nginx/sbin/nginx+0x4b4419)
openresty#9 0x427f16 (/usr/local/openresty-debug/nginx/sbin/nginx+0x427f16)
openresty#10 0x7f3daff27554 (/lib64/libc.so.6+0x22554)
openresty#11 0x42d537 (/usr/local/openresty-debug/nginx/sbin/nginx+0x42d537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.