Skip to content

Fixes lookup for echarts in theme files #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixes lookup for echarts in theme files #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/azul.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
Copy link
Contributor

@igorkasyanchuk igorkasyanchuk Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to find some a long term solution, because once I'll decide to upgrade JS I need to update it again, and I'm 100% sure I won't do it.

Copy link
Contributor Author

@umairabid umairabid Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not following, window should be always there for browsers. Can you give me example where it would fail?

Copy link
Contributor

@igorkasyanchuk igorkasyanchuk Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I decide to upgrade eCharts library, I need to make the same changes again

Copy link
Contributor

@igorkasyanchuk igorkasyanchuk Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I downloaded the wrong theme files? https://echarts.apache.org/en/download.html

Copy link
Contributor Author

@umairabid umairabid Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme files look good and I see your point we can't change theme files. The download files seems to be correct. Let me see how import charts load themes, will try to come up with solution that does not depend on changing theme files

Copy link
Contributor Author

@umairabid umairabid Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorkasyanchuk check #37

var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/bee-inspired.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/blue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/caravan.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/carp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/cool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/dark-blue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/dark-bold.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/dark-digerati.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/dark-fresh-cut.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/dark-mushroom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/dark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/eduardo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/forest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/fresh-cut.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/fruit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/gray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/green.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/helianthus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/infographic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/inspired.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/jazz.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/london.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/macarons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/macarons2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/mint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/rainbow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/red-velvet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/red.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/roma.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/royal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/sakura.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/shine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/tech-blue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/v5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/echarts/theme/vintage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// Browser globals
factory({}, root.echarts);
}
})(this, function(exports, echarts) {
})(this || window, function(exports, echarts) {
var log = function(msg) {
if (typeof console !== 'undefined') {
console && console.error && console.error(msg);
Expand Down