Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stream write to zip directly #863

Merged
merged 2 commits into from
Jun 22, 2021
Merged

feat: stream write to zip directly #863

merged 2 commits into from
Jun 22, 2021

Conversation

zhangzitao
Copy link
Contributor

@zhangzitao zhangzitao commented Jun 18, 2021

PR Details

Reduce the memory cost when saving file.

Description

If options has set password, the process will write to buffer in memory. Or it will write directly to the file.

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #863 (6675d43) into master (2cfcf9e) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files          31       31           
  Lines       10891    10899    +8     
=======================================
+ Hits        10614    10622    +8     
  Misses        155      155           
  Partials      122      122           
Flag Coverage Δ
unittests 97.45% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
file.go 83.67% <60.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cfcf9e...6675d43. Read the comment docs.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 18, 2021
@xuri
Copy link
Member

xuri commented Jun 21, 2021

Hi @zhangzitao, thanks for your PR! Could you add a test to cover the change?

@xuri xuri merged commit 24967a5 into qax-os:master Jun 22, 2021
@xuri
Copy link
Member

xuri commented Jun 22, 2021

LGTM, thank you.

jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants