Skip to content

Rename ErrMaxFileNameLength to ErrMaxFilePathLength #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2022

Conversation

sceneq
Copy link
Contributor

@sceneq sceneq commented May 16, 2022

PR Details

Description

Related Issue

#1229

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #1230 (548285a) into master (19a0cf3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          31       31           
  Lines       22164    22164           
=======================================
  Hits        21796    21796           
  Misses        248      248           
  Partials      120      120           
Flag Coverage Δ
unittests 98.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
errors.go 100.00% <ø> (ø)
file.go 85.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a0cf3...548285a. Read the comment docs.

@xuri xuri merged commit be5a403 into qax-os:master May 16, 2022
@xuri
Copy link
Member

xuri commented May 16, 2022

LGTM, thanks for your contribution.

xuri pushed a commit to carbin-gun/excelize that referenced this pull request Oct 9, 2022
xuri pushed a commit to JDavidVR/excelize that referenced this pull request Jul 11, 2023
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants