Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Showruler to Sheetview #1138

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Conversation

JDavidVR
Copy link
Contributor

@JDavidVR JDavidVR commented Feb 4, 2022

This adds showRuler="false" to hide ruler from sheetView

<sheetViews>
<sheetView workbookViewId="0" zoomScaleNormal="100" view="pageLayout" showRuler="false" tabSelected="1" showRowColHeaders="0" showGridLines="0"/>
</sheetViews>

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #1138 (319a5da) into master (862dc9d) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   98.21%   98.20%   -0.02%     
==========================================
  Files          29       29              
  Lines       18626    18630       +4     
==========================================
+ Hits        18294    18296       +2     
- Misses        226      228       +2     
  Partials      106      106              
Flag Coverage Δ
unittests 98.20% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sheetview.go 94.66% <50.00%> (-2.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862dc9d...319a5da. Read the comment docs.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I've left a comment.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2022
@xuri xuri merged commit 0f1fcb7 into qax-os:master Feb 6, 2022
@xuri
Copy link
Member

xuri commented Feb 6, 2022

LGTM, thank you very much.

@JDavidVR JDavidVR deleted the add-showruler-to-sheetview branch February 17, 2022 16:55
xuri pushed a commit to carbin-gun/excelize that referenced this pull request Oct 9, 2022
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Status: Feature
Development

Successfully merging this pull request may close these issues.

3 participants