-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added view configuration to SheetView #1136
Conversation
Hi @xuri I'm adding an additional configuration, for how sheet is presented: Normal: <sheetViews> <sheetView workbookViewId="0" tabSelected="1"/> </sheetViews> Page Break Preview: `view="pageBreakPreview" ` ``` <sheetViews> <sheetView workbookViewId="0" zoomScaleNormal="100" zoomScale="60" view="pageBreakPreview" tabSelected="1"/> </sheetViews> ``` Page Layout: `view="pageLayout"` ``` <sheetViews> <sheetView workbookViewId="0" zoomScaleNormal="100" view="pageLayout" tabSelected="1"/> </sheetViews> ``` Img reference from stackoverflow: https://i.stack.imgur.com/zxlGQ.png
Codecov Report
@@ Coverage Diff @@
## master #1136 +/- ##
==========================================
- Coverage 98.22% 98.20% -0.03%
==========================================
Files 29 29
Lines 18622 18626 +4
==========================================
Hits 18292 18292
- Misses 224 228 +4
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I have left comments, and please add unit test in ExampleFile_SetSheetViewOptions
.
LGTM, thank you. |
Hi @xuri
I'm adding an additional configuration, for how sheet is presented:
Normal:
Page Break Preview:
view="pageBreakPreview"
Page Layout:
view="pageLayout"