Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added view configuration to SheetView #1136

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Added view configuration to SheetView #1136

merged 3 commits into from
Feb 4, 2022

Conversation

JDavidVR
Copy link
Contributor

@JDavidVR JDavidVR commented Feb 3, 2022

Hi @xuri

I'm adding an additional configuration, for how sheet is presented:

Normal:

<sheetViews>
    <sheetView workbookViewId="0" tabSelected="1"/>
</sheetViews>

Page Break Preview: view="pageBreakPreview"

<sheetViews>
    <sheetView workbookViewId="0" zoomScaleNormal="100" zoomScale="60" view="pageBreakPreview" tabSelected="1"/>
</sheetViews>

Page Layout: view="pageLayout"

<sheetViews>
    <sheetView workbookViewId="0" zoomScaleNormal="100" view="pageLayout" tabSelected="1"/>
</sheetViews>

image

Hi @xuri 

I'm adding an additional configuration, for how sheet is presented:

Normal:
<sheetViews>
    <sheetView workbookViewId="0" tabSelected="1"/>
</sheetViews>

Page Break Preview: `view="pageBreakPreview" `

```
<sheetViews>
    <sheetView workbookViewId="0" zoomScaleNormal="100" zoomScale="60" view="pageBreakPreview" tabSelected="1"/>
</sheetViews>
```

Page Layout: `view="pageLayout"`

```
<sheetViews>
    <sheetView workbookViewId="0" zoomScaleNormal="100" view="pageLayout" tabSelected="1"/>
</sheetViews>
```

Img reference from stackoverflow: https://i.stack.imgur.com/zxlGQ.png
@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #1136 (d5ecbfb) into master (156bf6d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   98.22%   98.20%   -0.03%     
==========================================
  Files          29       29              
  Lines       18622    18626       +4     
==========================================
  Hits        18292    18292              
- Misses        224      228       +4     
  Partials      106      106              
Flag Coverage Δ
unittests 98.20% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sheetview.go 94.36% <0.00%> (-5.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156bf6d...d5ecbfb. Read the comment docs.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I have left comments, and please add unit test in ExampleFile_SetSheetViewOptions.

@xuri xuri self-requested a review February 4, 2022 05:43
@xuri xuri merged commit 862dc9d into qax-os:master Feb 4, 2022
@xuri
Copy link
Member

xuri commented Feb 4, 2022

LGTM, thank you.

@JDavidVR JDavidVR deleted the patch-1 branch February 17, 2022 16:54
xuri pushed a commit to carbin-gun/excelize that referenced this pull request Oct 9, 2022
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Status: Feature
Development

Successfully merging this pull request may close these issues.

3 participants