-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of main and optimizer initializations #98
Conversation
This pull request introduces 4 alerts and fixes 9 when merging b833c13 into 6e7e7a0 - view on LGTM.com new alerts:
fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## dev #98 +/- ##
==========================================
+ Coverage 51.48% 57.32% +5.83%
==========================================
Files 36 35 -1
Lines 5409 5279 -130
==========================================
+ Hits 2785 3026 +241
+ Misses 2624 2253 -371
Continue to review full report at Codecov.
|
This pull request fixes 9 alerts when merging dce7007 into 6e7e7a0 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge! 🚀
c3/main.py
Outdated
opt.set_exp(exp) | ||
opt.set_created_by(opt_config) | ||
opt.set_created_by(cfg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the location of the config file not the cfg dict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just went thorugh it with @nwittler, up to hotfix of the storing the right config in main.py, the code is good for merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request fixes 9 alerts when merging 13292a4 into e10518e - view on LGTM.com fixed alerts:
|
What
General cleanup of the script based infrastructure.
Why
There was a lot of baggage from rigid old scripts. To make the software as a whole more extendable and usable, this needed to be cleaned up.
How
Moved relevant code from c3.utils.parsers.py to the respective initialization methods or c3.main.py
Open Questions