Nit fix the missing include of thread #8988
Conversation
Notice this in our internal build system. `std::this_thread::yield()` would require the include of thread.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8988
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @qlzh727! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Not sure why the cla check failed, I have contributed to pytorch/pytorch project and the CLA should be under Google. Could any maintainer help me check for that? Thanks. |
|
Hi @qlzh727 , I don't recommend that you keep relying on the torchvision video decoder - we're deprecating it in favor of torchcodec: https://github.com/pytorch/torchcodec |
Ah, thanks for the information. Will keep that in mind. We don't actively rely on it, we just host it as a framework team, and need to make sure it is building correctly. |
Notice this in our internal build system.
std::this_thread::yield()would require the include of thread.