Undeprecate int constants for interpolation #7241
Merged
+110
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
changed the title
pmeier
added
module: transforms
deprecation
revert(ed)
NicolasHug
reviewed
Feb 14, 2023
NicolasHug
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Thanks a lot Philip.
Do we.. need to bring back support for it on the v2 transforms as well? Let's mark it as "nice to have" on #7217?
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
Reviewed By: vmoens Differential Revision: D44416623 fbshipit-source-id: e404afad4f4e9cab00c0365410cdeb588179378b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7205. TL;DR this PR undoes #7176, #5974, #5898 for the integer inputs for interpolation mode. They are now fully supported again and no longer emit a deprecation warning. I'll send a follow-up PR to add this functionality to the prototype transforms as well.
cc @vfdev-5