Fixed issue with padding on CI #5875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
reviewed
Apr 25, 2022
datumbox
reviewed
Apr 26, 2022
There was a problem hiding this comment.
@vfdev-5 I have undone your skipping of the ColourJitter tests. I believe the issue was fixed. by reverting the upstream PR in question.
I think this should fix the issue, let's wait for the CI results and if green we can merge.
| if padding_mode in ("reflect", "replicate"): | ||
| img = torch_pad(img, p, mode=padding_mode) | ||
| else: | ||
| img = torch_pad(img, p, mode=padding_mode, value=float(fill)) |
There was a problem hiding this comment.
There is a PR that resolves the accidental BC break at pytorch/pytorch#76307
It's not merged yet but we can go ahead and adopt this approach in TorchVision to avoid it regardless.
|
I'm merging this to fix the breakages from the previous nightly. Thanks for the contribution @vfdev-5 |
datumbox
approved these changes
Apr 26, 2022
datumbox
added
dependency issue
other
facebook-github-bot
pushed a commit
that referenced
this pull request
May 6, 2022
Summary: * Fixed issue with padding on CI * Disabled failing tests with color_jitter * Remove Jitter workaround Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095701 fbshipit-source-id: 433b74ba300044a7a95760f3eff0e0e267d8a67f Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5873