Support big endian for .flo file decoding #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 33c586d (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com> Reviewed By: kazhang Differential Revision: D32216691 fbshipit-source-id: 20a63606676b5ca02e16e752908be749fbdd6490
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://vision.middlebury.edu/flow/code/flow-code/README.txt,
.flo files contain a magic number which is to 'PIEH' in ascii.
Our previous code was relying on the expectation that this is equivalent to
202021.25on little endian archs. This PR updates the magic-number checks to also support big-endian archs.cc @pmeier