Remove p_value test for RandomHorizontalFlipVideo #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 88986fa (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
reviewed
Oct 27, 2021
| @pytest.mark.skipif(stats is None, reason="scipy.stats not available") | ||
| def test_random_horizontal_flip_video(self): | ||
| random_state = random.getstate() | ||
| random.seed(42) |
There was a problem hiding this comment.
strange that we set a seed there... We normally didn't do it in such tests...
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
Reviewed By: datumbox Differential Revision: D32064687 fbshipit-source-id: 629ee4cf2567b501128eddd23bc32f7befea50f2
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4506 (comment)
cc @pmeier