Replace all no_grad() instances with inference_mode() in reference scripts
#4629
Conversation
|
Hi @XoMute! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Please, add |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
It seems like some CI tests failed due to network issues. |
…ytorch#4629)" This reverts commit e08c9e3.
|
@oke-aditya Just to be sure we didn't miss something, is the revert related to issues you spotted or you are just testing something different? |
|
I wanted to test the performance difference between these two. No grad vs inference mode. I am not planning to open PR and revert this :) |
|
Sounds good. You never know! Thanks for the quick clarification. :) |
…4629) Reviewed By: NicolasHug Differential Revision: D31758309 fbshipit-source-id: 4a59a8c39d9964db3f7ae92e97ef21f04ee6709b
Closes #4624
All instances of
no_grad()seemed ok to replace withinference_mode()since all of them were related to evaluationcc @datumbox