-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PILToTensor and ConvertImageDtype classes in reference scripts #4495
Added PILToTensor and ConvertImageDtype classes in reference scripts #4495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prabhat00155, the numbers look OK though it would be good to provide also runs on the latest main to confirm.
For example on our docs we report that the mAP of the Faster R-CNN ResNet-50 FPN
model should e 37.0 not 36.9 that you got but I believe this is the result of a separate accuracy deterioration and not related to your changes. By having runs on the latest main you can prove that this PR is not to blame.
Finally below I left some comments for your consideration, let me know what you think:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
… scripts (#4495) Summary: * Added PILToTensor and ConvertImageDtype classes in reference scripts * Addressed review comments * Fixed TypeError * Addressed review comment Reviewed By: prabhat00155, NicolasHug Differential Revision: D31309550 fbshipit-source-id: 623e6c70d74348315118c269297d6d31bf4a68f6
…ytorch#4495) * Added PILToTensor and ConvertImageDtype classes in reference scripts * Addressed review comments * Fixed TypeError * Addressed review comment
…ytorch#4495) * Added PILToTensor and ConvertImageDtype classes in reference scripts * Addressed review comments * Fixed TypeError * Addressed review comment
…ytorch#4495) * Added PILToTensor and ConvertImageDtype classes in reference scripts * Addressed review comments * Fixed TypeError * Addressed review comment
Detection:
Without these changes:
With these changes:
Segmentation:
Without these changes:
With these changes:
cc @vfdev-5 @datumbox