Cleanup test suite related to torch.testing.assert_close
#4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Thanks @pmeier ! Happy about the check_stride default change :)
There was one last occurrence left, I just pushed it and will merge when green!
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
…4177) Summary: Co-authored-by: Nicolas Hug <nicolashug@fb.com> Reviewed By: fmassa Differential Revision: D29932693 fbshipit-source-id: 1cadf0578dd28cfa300dfc00f6db6faf0ff98b39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
assert_equalfromtest/_assert_utils.pytotest/common_utils.pysince after make assert_equal an example how to partialtorch.testing.assert_closepytorch#58918 we need to keep it permanently andcheck_stride=Falsesince this became the default in Don't check stride by default pytorch#60637.