Skip to content

Blitz / Autograd Tutorial : Add word to distinguish math formulas. #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sbrodehl
Copy link
Contributor

@sbrodehl sbrodehl commented Apr 2, 2020

In some browsers (Arch Linux + Chromium) math formulas are shown very small, so it was very hard to see the comma between the two adjacent formulas and thus, reading them.

For better reading comprehension I added the word where at the relevant position.

In some browsers (Arch Linux + Chromium) math formulas are shown very small, so it was very hard to see the comma between the two adjacent formulas and thus, reading them.

For better reading comprehension I added the word `where` at the relevant position.
@netlify
Copy link

netlify bot commented Apr 2, 2020

Deploy preview for pytorch-tutorials-preview failed.

Built with commit b639b52

https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/5e85c50539b3ed0006121981

@sbrodehl
Copy link
Contributor Author

sbrodehl commented Apr 2, 2020

Why is netlify unable to build this PR?

@sbrodehl
Copy link
Contributor Author

sbrodehl commented Apr 7, 2020

The underlying problem seems to be related to

I suspect that some CSS on the page is maybe affecting the measurements that MathJax is making in order to determine the font sizes.

I use Chromium Version 80.0.3987.163 (Official Build) Arch Linux (64-bit).

@sbrodehl
Copy link
Contributor Author

It looks like this still is an issue.
autograd_tutorial html_optional-reading-vector-calculus-using-autograd

Multiple issues and pull request tried to solve this, but no improvement can be seen.

Since the generated API docs look fine, e.g. torch.nn.Conv2d, maybe MathJax is not a good choice, but KaTex is?

@bigfootjon
Copy link
Member

Hi @sbrodehl, this was mistakenly closed due to a mixup with the default branch name. Unfortunately, I can't reopen the PR because the old master branch was deleted. Please create a new PR and reference this PR.

@sbrodehl
Copy link
Contributor Author

Thanks for the quick reply!
I have moved forward and replaced MathJax with KaTeX in a new PR #1362 , it is now the same as in the PyTorch Docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants