-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update audio preprocessing tutorial #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for pytorch-tutorials-preview ready! Built with commit e08a480 https://deploy-preview-797--pytorch-tutorials-preview.netlify.com |
Here's the existing tutorial, the source code, added in this PR derived from this notebook using this script. |
Here are the notes I wrote from our chats :) When the binaries are released on Jan 7, we want to showcase in the tutorial:
In a following update of the tutorial, we will want:
Lower priority items:
|
FYI #600 is an open issue about generated plots and white space around them |
I need some help with the example for augmentations. I tried to replicate what the PR example had in my collab, but I am missing some pieces:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
You are constructing
Is that what you mean?
They are in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
The release was pushed to Jan 14, so we have a few more days :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave some feedback on dataset section, but otherwise LGTM!
- We need to rebase/merge master, since the branch is out-of-date.
- We'll take a look at the preview once it is regenerated
- We need to test locally, since CI will fail until torchaudio is released.
- We can merge this PR once torchaudio is released :)
@CamiWilliams @vincentqb Could you all look at the build logs for this and flag what the build issue would be: https://app.circleci.com/jobs/github/pytorch/tutorials/21752 Assuming it might need 1.4 or an updated torchaudio version? Thanks! FYI @jlin27 |
This requires torchaudio 0.4.0 that isn't released yet. |
Great. Thanks for the heads up!
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Vincent QB <notifications@github.com>
Sent: Monday, January 13, 2020 10:26:48 AM
To: pytorch/tutorials <tutorials@noreply.github.com>
Cc: Brian Johnson <brianjo@fb.com>; Comment <comment@noreply.github.com>
Subject: Re: [pytorch/tutorials] Update audio preprocessing tutorial (#797)
@CamiWilliams<https://github.com/CamiWilliams> @vincentqb<https://github.com/vincentqb> Could you all look at the build logs for this and flag what the build issue would be: https://app.circleci.com/jobs/github/pytorch/tutorials/21752<https://urldefense.proofpoint.com/v2/url?u=https-3A__app.circleci.com_jobs_github_pytorch_tutorials_21752&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=BN8I0Mcl9uorfjFjY23GJA&m=tEAZnA1gHO9n-xq_tDd0nJv_rVfFt-Gc-7XJ3yDJAM0&s=tBvzd-09TUI_LzY9JCL5dsKHXkp5K1bTpgZfN4bAoxE&e=> Assuming it might need 1.4 or an updated torchaudio version? Thanks! FYI @jlin27<https://github.com/jlin27>
Jan 13 16:54:55 AttributeError: module 'torchaudio.functional' has no attribute 'compute_deltas'
This requires torchaudio 0.4.0 that isn't released yet.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#797?email_source=notifications&email_token=AALOH5PAZAA6J3IJ757RM7DQ5SW6RA5CNFSM4J6CM6FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIZYSSA#issuecomment-573802824>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALOH5JKPHTRFHNPETLKJOTQ5SW6RANCNFSM4J6CM6FA>.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! As mentioned before, once torchaudio 0.4.0 is released, we should rebase, rerun the build, and merge.
Binaries for torchaudio are now available :) Reference: pytorch/audio#410 |
The error below is due to sox, see pytorch/audio#171.
@CamiWilliams -- Can you trigger a rerun of the tests to see if the error persists? I can't reproduce offline. Let's wait until we know what happens before merging. |
Yay! Checks are all green now. Ready to merge! |
Nice job @CamiWilliams. Output looks good. :) |
Update audio preprocessing tutorial
Updating the audio tutorial for the Jan 7 release
In a following update of the tutorial, we will want:
Lower priority items: