-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Update C++ Extension Tutorial for AMD GPU #3197
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3197
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 15 PendingAs of commit c91a69b with merge base 08a9bcd ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @naromero77amd! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@pytorchbot rebase |
You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra. |
5314416
to
9221c18
Compare
9221c18
to
815e1b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naromero77amd it's OK to reference the article at the end of the tutorial, but imo it would be good to incorporate parts of its context into this tutorial, otherwise, in my humble opinion, it's not very helpful for the end user
I agree with @malfet. Also, all references should go to the Conclusion section as to where the user can go after completing this tutorial. |
815e1b7
to
2cc4cdc
Compare
My apologies for taking so long to follow-up on this PR. I should have added more background as to the purpose of this PR. The point of the PR was to just add a reference to the ROCm blog since this tutorial is already deprecated. This tutorial is superseded by this newer tutorial: which in the December 2024 time frame I created a separate PR to add a NOTE about AMD ROCm support. The NOTE itself is quite boring because there is nothing extra needed to support a custom HIP kernel in a PyTorch C++ extension. You just write a CUDA kernel and the hipify script takes care of the rest. I can certainly move the NOTE to the conclusion section if you prefer that. Let me know. |
@naromero77amd Please move to the conclusion section - thank you! |
Done |
@svekars There is a pending check-- does that require your approval? |
@svekars ping |
Fixes #2342
Description
This is a minor update to the C++ Extension with a note about AMD GPU support.
Checklist