Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of iterations in USB tutorial #2771

Merged
merged 16 commits into from
Mar 5, 2024

Conversation

atskae
Copy link
Contributor

@atskae atskae commented Feb 21, 2024

Fixes #2711

Description

Reduces the number of training iterations from 4,000 to 500, which now runs for 3 minutes with an accuracy of 87%.
Also fixes the broken image link on the USB framework.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

Copy link

pytorch-bot bot commented Feb 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2771

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit da46b62 with merge base 475671e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@@ -17,7 +17,7 @@
This tutorial will walk you through the basics of using the USB lighting
package.
Let's get started by training a ``FreeMatch``/``SoftMatch`` model on
CIFAR-10 using pretrained ViT!
CIFAR-10 using pretrained Vision Transformers (ViT)!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote out what SSL and ViT stood for (please double check) since they are used throughout the tutorial and initially I didn't know what they meant. Maybe for ML experts they are obvious...

@svekars
Copy link
Contributor

svekars commented Feb 21, 2024

cc: @Hhhhhhao

@atskae
Copy link
Contributor Author

atskae commented Feb 21, 2024

Should I be concerned with this warning?

/var/lib/jenkins/workspace/advanced/usb_semisup_learn.rst: WARNING: document isn't included in any toctree

@atskae
Copy link
Contributor Author

atskae commented Feb 21, 2024

Thanks for the initial comments! Hopefully I addressed the main issues, though I'm still not sure why CI is hanging/failing... As a newcomer I'd appreciate any help, thank you!

@atskae atskae requested a review from svekars February 21, 2024 19:57
@atskae atskae marked this pull request as ready for review February 21, 2024 19:57
@atskae
Copy link
Contributor Author

atskae commented Feb 21, 2024

I can't seem to add @Hhhhhhao as a reviewer or add labels to the PR 😓

@atskae
Copy link
Contributor Author

atskae commented Feb 22, 2024

Run pyspelling
Misspelled words:
<url-free> beginner_source/colab.rst
--------------------------------------------------------------------------------
Nvidia
--------------------------------------------------------------------------------

!!!Spelling check failed!!!

How should I address this error? Do we make an exception or should I avoid using this word?

atskae and others added 4 commits February 23, 2024 13:55
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
@atskae atskae requested a review from svekars February 23, 2024 18:56
Copy link
Contributor Author

@atskae atskae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comments!

@atskae
Copy link
Contributor Author

atskae commented Feb 28, 2024

@Hhhhhhao Are there any other changes that I should make?

@Hhhhhhao
Copy link
Contributor

@Hhhhhhao Are there any other changes that I should make?

I think that would be all for now. Thanks for the help!

@svekars svekars merged commit 2b7f15e into pytorch:main Mar 5, 2024
19 checks passed
@atskae atskae deleted the atskae/reduce_iterations_usb branch March 5, 2024 21:59
@atskae atskae mentioned this pull request Mar 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Disabling advanced/usb_semisup_learn
4 participants