Skip to content

Fix torch_vision_tutorial.rst #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

ver2king
Copy link

@ver2king ver2king commented Jun 7, 2023

Fixes #960

Description

Checklist

labels = torch.ones((num_objs,), dtype=torch.int64)

to the following:

label = torch.as_tensor(obj_ids, dtype=torch.int64)

cc @datumbox @nairbv @fmassa @NicolasHug @YosuaMichael

ver2king added 3 commits June 7, 2023 12:13
Refer to data_tutorial.py
Add 2 lines of code to control the environment, if used with Conda
Change the following code line:

labels = torch.ones((num_objs,), dtype=torch.int64)

to

label = torch.as_tensor(obj_ids, dtype=torch.int64)
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 7, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2444

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3aef9fe:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 3aef9fe
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/64836de78a39f50008962803
😎 Deploy Preview https://deploy-preview-2444--pytorch-tutorials-preview.netlify.app/beginner/basics/data_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added torchvision Issues relating to image/video tutorials docathon-h1-2023 A label for the docathon in H1 2023 easy and removed cla signed labels Jun 7, 2023
@svekars svekars added the module: vision Torchvision issues label Jun 8, 2023
@github-actions github-actions bot removed cla signed module: vision Torchvision issues labels Jun 8, 2023
@svekars
Copy link
Contributor

svekars commented Jun 8, 2023

I'm not sure why we are modifying all these other files apart from intermediate_source/torchvision_tutorial.rst

@ver2king
Copy link
Author

ver2king commented Jun 8, 2023

@svekars
Yes only the torchvision_tutorial.rst needs to be modified. I used git diff to check before I submitted the PR.
However, in case any other differences except the file intended to be fixed, I will submit another PR.

Copy link
Contributor

@kit1980 kit1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ver2king your PR currently includes 16 files, including your ".idea" folder.

On the tutorial change itself, you need to update usages of the variable after the rename.
Also please verify the changes by running the code, don't submit blindly.

ver2king added 6 commits June 9, 2023 13:18
Based on the proposed review for this PR
Based on the proposed review for this PR
Based on the proposed request for this PR
Based on the proposed request for this PR
Based on the proposed request for this PR
Based on the proposed request for this PR
Update the file based on the proposed request for this PR (Changes in the file are not relevant to the intended tutorial purpose)
@ver2king ver2king closed this Jun 9, 2023
@ver2king ver2king deleted the fix_RCNN_tutorial branch June 9, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docathon-h1-2023 A label for the docathon in H1 2023 easy torchvision Issues relating to image/video tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask-RCNN tutorial one-line change suggestion
4 participants