Skip to content

Update feature classification labels #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2020
Merged

Update feature classification labels #1035

merged 4 commits into from
Jul 4, 2020

Conversation

jlin27
Copy link
Contributor

@jlin27 jlin27 commented Jun 18, 2020

Related to this docs PR to update the feature classification labels:
pytorch/pytorch#39966

@netlify
Copy link

netlify bot commented Jun 18, 2020

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 9a7250d

https://deploy-preview-1035--pytorch-tutorials-preview.netlify.app

@jlin27 jlin27 requested a review from jspisak June 18, 2020 17:16
Copy link
Contributor

@jspisak jspisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netlify if not working.. :( Raw changes look good though.

@@ -104,7 +104,7 @@
######################################################################
# Performance Gains
# -------------------------------------------------------------------------------------------
# The most significant performance gains are observed on NVidia's hardware with
# The most significant performance gains are observed on NVidia's hardware with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVidia --> Nvidia

Copy link
Contributor

@jspisak jspisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change but overall lgtm. thanks!

@jlin27
Copy link
Contributor Author

jlin27 commented Jun 23, 2020

@jspisak - Thanks for the review. Updated w/ your suggestion and will merge once all the tests pass.

@jlin27 jlin27 merged commit 0d48b72 into pytorch:master Jul 4, 2020
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
Update feature classification labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants