Skip to content

transformer_tutorial.py mentions log softmax even though it's not used. #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Fraser-Greenlee opened this issue Dec 29, 2019 · 3 comments · Fixed by #2420
Closed

transformer_tutorial.py mentions log softmax even though it's not used. #800

Fraser-Greenlee opened this issue Dec 29, 2019 · 3 comments · Fixed by #2420

Comments

@Fraser-Greenlee
Copy link

After this merge https://github.com/pytorch/tutorials/pull/695/files
LogSoftmax is not used even though the tutorial text says it is.
I thought the code was wrong and added the old softmax in which made it preform worse.
@Fraser-Greenlee
Copy link
Author

It would be great to update the text & explain why a softmax is not used.

@Fraser-Greenlee
Copy link
Author

Why the softmax was removed #682

@Fraser-Greenlee
Copy link
Author

Where softmax is still mentioned https://github.com/pytorch/tutorials/blob/master/beginner_source/transformer_tutorial.py#L44

@j3soon j3soon mentioned this issue Jun 3, 2023
Merged
4 tasks
svekars pushed a commit that referenced this issue Jun 9, 2023
@j3soon
Fix log-softmax unused issue (#2420)
3b20fe6 
Fixes: #800

Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix log-softmax unused issue
1 participant
@Fraser-Greenlee