Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code-blocks are missing because of reST syntax error #1496

Closed
9bow opened this issue May 1, 2021 · 1 comment
Closed

Some code-blocks are missing because of reST syntax error #1496

9bow opened this issue May 1, 2021 · 1 comment

Comments

@9bow
Copy link
Contributor

9bow commented May 1, 2021

Hi,

While tidy up reStructuredText syntax for translating tutorials into Korean, I found some code-blocks are missing because of reST syntax error.

For example, Extending dispatcher for a new backend in C++ tutorial, there's a code block after [To create a Tensor on PrivateUse1 backend, you need to set dispatch key in TensorImpl constructor.] sentence.

There're also other unintended hidden code-blocks.

Here's a list I found:

Tutorial Source
Extending dispatcher for a new backend in C++ code-block after To create a Tensor on PrivateUse1 backend, you need to set dispatch key in TensorImpl constructor.
Making Native Android Application that uses PyTorch prebuilt libraries code-block after You should see logs with tag ‘PyTorchNativeApp’ that prints x, y, and the result of the model forward, which we print with log function in NativeApp/app/src/main/cpp/pytorch_nativeapp.cpp.
(prototype) FX Graph Mode Post Training Static Quantization code-block after The FX Graph Mode API looks like the following:
Hyperparameter tuning with Ray Tune code-block after If you run the code, an example output could look like this:
Dynamic Parallelism in TorchScript code-block after Let’s use the profiler along with the Chrome trace export functionality to visualize the performance of our parallelized model:
Extending TorchScript with Custom C++ Operators code-block after At this point, we should be able to build the application:, code-block after And run it without passing a model just yet:, AND code-block after If we then pass this serialized model to our C++ application, we can run it straight away:

I'd like to fix those tutorials and pull request about this.

holly1238 added a commit that referenced this issue May 3, 2021
Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com>
@holly1238
Copy link
Contributor

Closing this PR. #1497 has been merged to fix the issue.

rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this issue Nov 29, 2021
Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants