Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third part link for the text domain tutorials #1460

Closed
zhangguanheng66 opened this issue Apr 6, 2021 · 3 comments · Fixed by #2364
Closed

Third part link for the text domain tutorials #1460

zhangguanheng66 opened this issue Apr 6, 2021 · 3 comments · Fixed by #2364
Assignees
Labels
docathon-h1-2023 A label for the docathon in H1 2023 easy incorrect link

Comments

@zhangguanheng66
Copy link
Contributor

zhangguanheng66 commented Apr 6, 2021

The following three tutorials link the author's name (see "Author: Sean Robertson") to a third-party repo, which is not maintained anymore. Should we just remove those names in the tutorials?

https://pytorch.org/tutorials/intermediate/char_rnn_classification_tutorial.html
https://pytorch.org/tutorials/intermediate/char_rnn_generation_tutorial.html
https://pytorch.org/tutorials/intermediate/seq2seq_translation_tutorial.html

cc @svekars @carljparker @brianjo @cpuhrsch

@brianjo
Copy link
Contributor

brianjo commented Apr 6, 2021

Yes thanks. I'll take care of it.

@brianjo brianjo self-assigned this Apr 6, 2021
@svekars
Copy link
Contributor

svekars commented Mar 8, 2023

Needs to be updated to Author's profile: https://github.com/spro rather than the repo as it's pointing at the moment.

@svekars svekars added easy docathon-h1-2023 A label for the docathon in H1 2023 labels May 31, 2023
@NeoKish
Copy link
Contributor

NeoKish commented May 31, 2023

/assigntome

NeoKish added a commit to NeoKish/tutorials that referenced this issue May 31, 2023
svekars pushed a commit that referenced this issue May 31, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docathon-h1-2023 A label for the docathon in H1 2023 easy incorrect link
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants