[ONNX] Create empty opset 17 symbolic file #83287

justinchuby · 2022-08-11T19:01:51Z

Stack from ghstack (oldest at bottom):

-> [ONNX] Create empty opset 17 symbolic file #83287

The PR

Creates an empty symbolic file to house the new ops defined in ONNX 17
Increments the max version to 17 and fixes the doc for version 16
Enables tests for opset 17
Updates the IR version in export.cpp

The PR creates an empty symbolic file to house the new ops defined in ONNX 17. It also increments the max version to 17 and fixes the doc for version 16. [ghstack-poisoned]

facebook-github-bot · 2022-08-11T19:01:57Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83287
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit ca29d0c (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

The PR creates an empty symbolic file to house the new ops defined in ONNX 17. It also increments the max version to 17 and fixes the doc for version 16. [ghstack-poisoned]

The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 [ghstack-poisoned]

The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 - Updates the IR version in `export.cpp` [ghstack-poisoned]

test/onnx/test_pytorch_onnx_onnxruntime.py

torch/csrc/jit/serialization/export.cpp

test/onnx/test_pytorch_onnx_onnxruntime.py

The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 - Updates the IR version in `export.cpp` [ghstack-poisoned]

The PR creates an empty symbolic file to house the new ops defined in ONNX 17. It also increments the max version to 17 and fixes the doc for version 16. ghstack-source-id: fcf7555 Pull Request resolved: pytorch#83287

The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 - Updates the IR version in `export.cpp` [ghstack-poisoned]

The PR creates an empty symbolic file to house the new ops defined in ONNX 17. It also increments the max version to 17 and fixes the doc for version 16. ghstack-source-id: 37517d8 Pull Request resolved: #83287

test/onnx/test_pytorch_onnx_onnxruntime.py

torch/csrc/jit/serialization/export.cpp

shubhambhokare1 · 2022-08-16T17:59:22Z

torch/onnx/_constants.py

@@ -2,7 +2,7 @@

 ONNX_ARCHIVE_MODEL_PROTO_NAME = "__MODEL_PROTO"
 onnx_default_opset = 13
-onnx_main_opset = 16


Do we make a note of newly updated main opsets anywhere in the documentation?

Not that I know of. onnx_main_opset is an internal value that tracks the latest onnx opset version. Any suggestions?

titaiwangms

🍻

justinchuby · 2022-08-17T01:09:00Z

cc @BowenBao

thiagocrepaldi

LGTM. Still think we should discuss further the difference between tested and supported opsets versions, but this PR is about opset 17, so that is fine
I still cant understand why we wouldn't test an opset that is supported by the source-code.

justinchuby · 2022-08-18T20:03:08Z

@pytorchbot rebase

pytorchmergebot · 2022-08-18T20:04:38Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-08-18T20:04:43Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/master gh/justinchuby/8/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging test/onnx/test_pytorch_onnx_onnxruntime.py
Auto-merging torch/onnx/_constants.py
CONFLICT (content): Merge conflict in torch/onnx/_constants.py
error: could not apply adb233fb55... [ONNX] Create empty opset 17 symbolic file
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply adb233fb55... [ONNX] Create empty opset 17 symbolic file

Raised by https://github.com/pytorch/pytorch/actions/runs/2885076323

BowenBao · 2022-08-18T22:14:23Z

@pytorchbot merge -g

pytorchmergebot · 2022-08-18T22:16:42Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-08-18T22:16:42Z

Merge failed
Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.
Raised by https://github.com/pytorch/pytorch/actions/runs/2885742210

justinchuby · 2022-08-18T22:24:34Z

I will rebase and merge

The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 - Updates the IR version in `export.cpp` [ghstack-poisoned]

The PR creates an empty symbolic file to house the new ops defined in ONNX 17. It also increments the max version to 17 and fixes the doc for version 16. ghstack-source-id: 46909b8 Pull Request resolved: #83287

justinchuby · 2022-08-18T23:30:44Z

@pytorchbot merge -g

pytorchmergebot · 2022-08-18T23:31:59Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

Summary: The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 - Updates the IR version in `export.cpp` Pull Request resolved: #83287 Approved by: https://github.com/thiagocrepaldi, https://github.com/AllenTiTaiWang, https://github.com/BowenBao Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/05849eafb92def1c0071d5a7b0bb782360145cbb Reviewed By: atalman Differential Revision: D38853638 fbshipit-source-id: b57486aaaf67e35604379701b8ffdd9db6d204ba

[ONNX] Create empty opset 17 symbolic file

a4015d9

The PR creates an empty symbolic file to house the new ops defined in ONNX 17. It also increments the max version to 17 and fixes the doc for version 16. [ghstack-poisoned]

justinchuby requested review from BowenBao and shubhambhokare1 as code owners August 11, 2022 19:01

This was referenced Aug 11, 2022

[ONNX] Update the script for version updates #83283

Closed

[ONNX] Update the default opset to version 14 #83284

Closed

facebook-github-bot added the cla signed label Aug 11, 2022

justinchuby requested a review from thiagocrepaldi August 11, 2022 19:02

Update on "[ONNX] Create empty opset 17 symbolic file"

538e5de

The PR creates an empty symbolic file to house the new ops defined in ONNX 17. It also increments the max version to 17 and fixes the doc for version 16. [ghstack-poisoned]

Update on "[ONNX] Create empty opset 17 symbolic file"

f578d76

The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 [ghstack-poisoned]

justinchuby linked an issue Aug 11, 2022 that may be closed by this pull request

[ONNX] Support opset 17 operators #81075

Closed

33 tasks

Update on "[ONNX] Create empty opset 17 symbolic file"

c0b231e

The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 [ghstack-poisoned]

pytorchbot added the open source label Aug 11, 2022

Update on "[ONNX] Create empty opset 17 symbolic file"

a9838f3

The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 [ghstack-poisoned]

Update on "[ONNX] Create empty opset 17 symbolic file"

144723c

The PR - Creates an empty symbolic file to house the new ops defined in ONNX 17 - Increments the max version to 17 and fixes the doc for version 16 - Enables tests for opset 17 [ghstack-poisoned]

justinchuby added the module: onnx Related to torch.onnx label Aug 11, 2022

thiagocrepaldi requested changes Aug 12, 2022

View reviewed changes

test/onnx/test_pytorch_onnx_onnxruntime.py Outdated Show resolved Hide resolved

torch/csrc/jit/serialization/export.cpp Outdated Show resolved Hide resolved

test/onnx/test_pytorch_onnx_onnxruntime.py Outdated Show resolved Hide resolved

justinchuby requested a review from thiagocrepaldi August 12, 2022 23:24

justinchuby added topic: improvements topic category topic: new features topic category and removed topic: improvements topic category labels Aug 12, 2022

titaiwangms reviewed Aug 15, 2022

View reviewed changes

test/onnx/test_pytorch_onnx_onnxruntime.py Show resolved Hide resolved

titaiwangms self-assigned this Aug 15, 2022

justinchuby commented Aug 16, 2022

View reviewed changes

torch/csrc/jit/serialization/export.cpp Show resolved Hide resolved

shubhambhokare1 reviewed Aug 16, 2022

View reviewed changes

titaiwangms approved these changes Aug 17, 2022

View reviewed changes

thiagocrepaldi approved these changes Aug 17, 2022

View reviewed changes

BowenBao approved these changes Aug 18, 2022

View reviewed changes

pytorchmergebot added the Merged label Aug 19, 2022

pytorchmergebot closed this in 05849ea Aug 19, 2022

facebook-github-bot deleted the gh/justinchuby/8/head branch August 22, 2022 14:19

justinchuby mentioned this pull request Aug 23, 2022

[ONNX] Support opset 17 operators #81075

Closed

33 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] Create empty opset 17 symbolic file #83287

[ONNX] Create empty opset 17 symbolic file #83287

justinchuby commented Aug 11, 2022 •

edited

Loading

facebook-github-bot commented Aug 11, 2022 •

edited

Loading

shubhambhokare1 Aug 16, 2022

justinchuby Aug 16, 2022

titaiwangms left a comment

justinchuby commented Aug 17, 2022

thiagocrepaldi left a comment

justinchuby commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

BowenBao commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

justinchuby commented Aug 18, 2022

justinchuby commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

[ONNX] Create empty opset 17 symbolic file #83287

[ONNX] Create empty opset 17 symbolic file #83287

Conversation

justinchuby commented Aug 11, 2022 • edited Loading

facebook-github-bot commented Aug 11, 2022 • edited Loading

🔗 Helpful links

✅ No Failures (0 Pending)

shubhambhokare1 Aug 16, 2022

Choose a reason for hiding this comment

justinchuby Aug 16, 2022

Choose a reason for hiding this comment

titaiwangms left a comment

Choose a reason for hiding this comment

justinchuby commented Aug 17, 2022

thiagocrepaldi left a comment

Choose a reason for hiding this comment

justinchuby commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

BowenBao commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

justinchuby commented Aug 18, 2022

justinchuby commented Aug 18, 2022

pytorchmergebot commented Aug 18, 2022

justinchuby commented Aug 11, 2022 •

edited

Loading

facebook-github-bot commented Aug 11, 2022 •

edited

Loading