[ONNX] Support optional type (#68793) #73284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: BowenBao <bowbao@microsoft.com> Co-authored-by: neginraoof <neginmr@utexas.edu> [ghstack-poisoned]
This was referenced Feb 23, 2022
CI Flow Status⚛️ CI FlowRuleset - Version:
|
This was referenced Feb 23, 2022
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b8fab95 (more details on the Dr. CI page): Expand to see more
🕵️ 6 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
facebook-github-bot
added
the
oncall: jit
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: BowenBao <bowbaomicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Feb 23, 2022
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: BowenBao <bowbaomicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> ghstack-source-id: df051bd Pull Request resolved: #73284
BowenBao
added
the
onnx-needs-import
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: BowenBao <bowbaomicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> [ghstack-poisoned]
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: BowenBao <bowbaomicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Mar 2, 2022
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: BowenBao <bowbaomicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> ghstack-source-id: 297f9ee Pull Request resolved: #73284
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@suo can you please check(or add someone) who knows whether methods modified in |
malfet
reviewed
Mar 3, 2022
|
sorry, missed the ping. @eellison do you mind looking over the JIT changes |
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: garymm <garymiguelmicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> Differential Revision: [D34625646](https://our.internmc.facebook.com/intern/diff/D34625646) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 26, 2022
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: BowenBao <bowbaomicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> ghstack-source-id: 48155ca Pull Request resolved: #73284
|
@malfet rebased again to resolve conflicts. Please import |
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: garymm <garymiguelmicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> Differential Revision: [D34625646](https://our.internmc.facebook.com/intern/diff/D34625646) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 28, 2022
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: BowenBao <bowbaomicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> ghstack-source-id: c56814f Pull Request resolved: #73284
justinchuby
reviewed
Apr 28, 2022
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: garymm <garymiguelmicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> Differential Revision: [D34625646](https://our.internmc.facebook.com/intern/diff/D34625646) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
May 2, 2022
Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Co-authored-by: BowenBao <bowbaomicrosoft.com> Co-authored-by: neginraoof <neginmrutexas.edu> ghstack-source-id: 9ef86bb Pull Request resolved: #73284
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This change once again regresses some of the internal model conversion tests. [Edit] As @BowenBao suggested, reverting |
malfet
reviewed
May 4, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2022
Summary: Pull Request resolved: #73284 Some important ops won't support optional type until opset 16, so we can't fully test things end-to-end, but I believe this should be all that's needed. Once ONNX Runtime supports opset 16, we can do more testing and fix any remaining bugs. Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D34625646 Pulled By: malfet fbshipit-source-id: 537fcbc1e9d87686cc61f5bd66a997e99cec287b Co-authored-by: BowenBao <bowbao@microsoft.com> Co-authored-by: neginraoof <neginmr@utexas.edu> Co-authored-by: Nikita Shulga <nshulga@fb.com>
|
Hey @BowenBao. |
garymm
added
release notes: onnx
15 tasks
|
@BowenBao @malfet @eellison This PR is likely to have broken TorchVision. Please see pytorch/vision#5971 for details. @pmeier has done a bisection and confirmed that this commit is responsible. Can you please revert? |
atalman
added a commit
to atalman/pytorch
that referenced
this pull request
May 12, 2022
This reverts commit 679fc90.
|
I'll look at this today. It took us 3 months to get this PR merged so even though it's generally bad practice, I'd really like to fix forward if possible. |
|
@garymm Thanks for coming back to me. I understand it, if you want to explore fixing the issue rather than reverting the whole PR. Just please prioritise this because TorchVision's ONNX export is broken for the detection models and we are dangerous close to the release. I'm also concerned that the longer we leave this in, the harder it will be to revert it if a fix can't be completed soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Some important ops won't support optional type until opset 16,
so we can't fully test things end-to-end, but I believe this should
be all that's needed. Once ONNX Runtime supports opset 16,
we can do more testing and fix any remaining bugs.
Co-authored-by: garymm garymiguel@microsoft.com
Co-authored-by: neginraoof neginmr@utexas.edu
Differential Revision: D34625646