fix formatter to not raise on empty header, update build image #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy Preview for pytorch-dot-org-preview processing. 🔨 Explore the source changes: 7fc2a85 🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/615cb1dc06f1c90008dabca3 |
malfet
approved these changes
Oct 5, 2021
|
I don;t see a circleci job on the PR, so I hope it solves the problem. Locally the build script worked. 🤷 |
This is sort of expected behaviour per pytorch.github.io/.circleci/config.yml Lines 50 to 55 in 0fb10a7 |
malfet
added a commit
that referenced
this pull request
Oct 6, 2021
Introduced by #855, but its hard to test in PR considering how config.yml is written
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #853
@malfet, @brianjo