-
Notifications
You must be signed in to change notification settings - Fork 307
[Mobile] Landing page update for v1.6.0 #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated text for PyTorch Mobile landing page and the workflow asset image.
Deploy preview for pytorch-dot-org-preview ready! Built with commit 5928ef3 https://deploy-preview-409--pytorch-dot-org-preview.netlify.app |
_mobile/home.md
Outdated
Learn more or get started on [Android]({{site.baseurl}}/mobile/android) or [iOS]({{site.baseurl}}/mobile/ios). | ||
Key features of PyTorch Mobile: | ||
|
||
* Available for iOS, Android and Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation to link to iOS and Android landing pages
* Support for XNNPACK floating point kernel libraries for Arm CPUs | ||
* Integration of QNNPACK for 8-bit quantized kernels. Includes support for per-channel quantization, dynamic quantization and more | ||
* Build level optimization and selective compilation depending on the operators needed for user applications, i.e., the final binary size of the app is determined by the actual operators the app needs | ||
* Support for hardware backends like GPU, DSP, NPU will be available soon | ||
|
||
<div class="text-center"> | ||
<img src="{{ site.baseurl }}/assets/images/pytorch-mobile.png" width="100%"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation to add a simple caption above this image. Not just helpful for sighted users, but also useful for visually impaired users or in situations if the the image doesn't render for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Added a string above the figure. Let me know if that works for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That description sounds good 👍
@gaurav-work - These changes look good to me. I added 2 quick suggestions. Would you want these changes merged immediately onto the live site or are we waiting until the 1.6 release (7/21)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm!
@gaurav-work - If this will be for 1.6, I'll merge the day of the 1.6 launch if that works for you and the team.
Update: Checked with Gaurav and I will land these changes morning of the 1.6 launch.
Updated text for PyTorch Mobile landing page and the workflow asset image.