Skip to content

Conversation

@svekars
Copy link
Collaborator

@svekars svekars commented Jul 24, 2024

No description provided.

@svekars svekars requested review from kyliewd and seemethere July 24, 2024 17:53
@netlify
Copy link

netlify bot commented Jul 24, 2024

👷 Deploy Preview for pytorch-dot-org-preview processing.

Name Link
🔨 Latest commit 2bb0040
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/66a145ab2b59a900080caea4

@svekars svekars requested review from atalman and cjyabraham July 24, 2024 17:53

`torch.distributed.pipelining` provides a toolkit that allows for easy implementation of pipeline parallelism on general models while also offering composability with other common PyTorch distributed features like DDP, FSDP, or tensor parallel.

For more information on this please refer to our [documentation](https://pytorch.org/docs/main/notes/get_start_xpu.html) and [tutorial](https://pytorch.org/tutorials/intermediate/pipelining_tutorial.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have the wrong link for documentation: https://pytorch.org/docs/main/distributed.pipelining.htm

Thanks for adding the blurb though!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information on this please refer to our [documentation](https://pytorch.org/docs/main/notes/get_start_xpu.html) and [tutorial](https://pytorch.org/tutorials/intermediate/pipelining_tutorial.html).
For more information on this please refer to our [documentation](https://pytorch.org/docs/main/distributed.pipelining.html) and [tutorial](https://pytorch.org/tutorials/intermediate/pipelining_tutorial.html).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

seemethere
seemethere previously approved these changes Jul 24, 2024
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere seemethere dismissed their stale review July 24, 2024 18:11

Let's fix Howard's link first

@seemethere seemethere merged commit 07de6fa into site Jul 24, 2024
@seemethere seemethere deleted the add-pytorch-blog-2.4 branch July 24, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants