Skip to content

Update install matrix for PT 1.0 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 7, 2018
Merged

Update install matrix for PT 1.0 #133

merged 5 commits into from
Dec 7, 2018

Conversation

JoelMarcey
Copy link
Contributor

No description provided.

@JoelMarcey JoelMarcey requested review from orionr, soumith and pjh5 December 6, 2018 23:42
@facebook-netlify-bot
Copy link

facebook-netlify-bot commented Dec 6, 2018

Deploy preview for infallible-bhabha-cf3724 ready!

Built with commit 9897cbd

https://deploy-preview-133--infallible-bhabha-cf3724.netlify.com

Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to get all of those cu92 -> cu100 changes! Hopefully in the review I call them all out.


```bash
conda install pytorch cuda92 -c pytorch
conda install pytorch cuda10.0 -c pytorch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be cuda100 given the first usage at the beginning of the changes? @pjh5 and @soumith?

pip3 install torchvision
```

```
# Python 3.6
pip3 install http://download.pytorch.org/whl/cu92/torch-0.4.1-cp36-cp36m-win_amd64.whl
pip3 install http://download.pytorch.org/whl/cu92/torch-1.0.0-cp36-cp36m-win_amd64.whl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be cu92 -> cu100?

```

```bash
# Python 3.5
pip3 install http://download.pytorch.org/whl/cu92/torch-0.4.1-cp35-cp35m-linux_x86_64.whl
pip3 install http://download.pytorch.org/whl/cu92/torch-1.0.0-cp35-cp35m-linux_x86_64.whl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be cu92 -> cu100?

pip3 install torchvision
```

```bash
# Python 3.6
pip3 install http://download.pytorch.org/whl/cu92/torch-0.4.1-cp36-cp36m-linux_x86_64.whl
pip3 install http://download.pytorch.org/whl/cu92/torch-1.0.0-cp36-cp36m-linux_x86_64.whl
pip3 install torchvision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be cu92 -> cu100?

"preview,pip,windows,cuda9.2,python3.5":
"# Preview Build Not Yet Available on Windows.",
"preview,pip,windows,cuda10.0,python3.5":
"pip install numpy torchvision_nightly<br />pip install torch_nightly -f https://download.pytorch.org/whl/nightly/cu92/torch_nightly.html",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be cu92 -> cu100?

"preview,pip,windows,cuda9.2,python3.6":
"# Preview Build Not Yet Available on Windows.",
"preview,pip,windows,cuda10.0,python3.6":
"pip install numpy torchvision_nightly<br />pip install torch_nightly -f https://download.pytorch.org/whl/nightly/cu92/torch_nightly.html",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be cu92 -> cu100?

"preview,pip,windows,cuda9.2,python3.7":
"# Preview Build Not Yet Available on Windows.",
"preview,pip,windows,cuda10.0,python3.7":
"pip install numpy torchvision_nightly<br />pip install torch_nightly -f https://download.pytorch.org/whl/nightly/cu92/torch_nightly.html",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be cu92 -> cu100?

@@ -790,20 +784,20 @@ function commandMessage(key) {
"preview,libtorch,linux,cuda9.0,cplusplus":
"Download here: <br/><a href='https://download.pytorch.org/libtorch/nightly/cu90/libtorch-shared-with-deps-latest.zip'>https://download.pytorch.org/libtorch/nightly/cu90/libtorch-shared-with-deps-latest.zip</a>",

"preview,libtorch,linux,cuda9.2,cplusplus":
"preview,libtorch,linux,cuda10.0,cplusplus":
"Download here: <br/><a href='https://download.pytorch.org/libtorch/nightly/cu92/libtorch-shared-with-deps-latest.zip'>https://download.pytorch.org/libtorch/nightly/cu92/libtorch-shared-with-deps-latest.zip</a>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be cu92 -> cu100?

"preview,libtorch,macos,cuda9.2,cplusplus":
"# Currently only available CPU-only / no CUDA.",
"preview,libtorch,macos,cuda10.0,cplusplus":
"Download here: <br/><a href='https://download.pytorch.org/libtorch/nightly/cu92/libtorch-macos-latest.zip'>https://download.pytorch.org/libtorch/nightly/cpu/libtorch-macos-latest.zip</a>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be cu92 -> cu100?

@JoelMarcey
Copy link
Contributor Author

@orionr Great catches! Fixed.

Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one last nit change. Looks good!

@JoelMarcey JoelMarcey merged commit c96b60d into pytorch:site Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants