DOC: release documentation version should be major.minor #72706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 3aa0595 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
albanD
reviewed
Feb 11, 2022
| @@ -326,14 +326,11 @@ | |||
| # Customized html_title here. | |||
| # Default is " ".join(project, release, "documentation") if not set | |||
| if RELEASE: | |||
| # remove hash (start with 'a') from version number if any | |||
| version_end = torch_version.find('a') | |||
| if version_end == -1: | |||
There was a problem hiding this comment.
What was the case where this would not find the hash? Is it guaranteed that the version here is well formed as X.Y... ?
There was a problem hiding this comment.
What was the case where this would not find the hash?
When building the release documentation from a non-tag, the __version__ is something like 1.10.0a0+git2aa19f3. So the old code would change that to 1.10.0. When building from a tag, the __version__ is already 1.10.0.
Is it guaranteed that the version here is well formed as
X.Y...?
I think if the __version__ is not of the form ..>don't care>, something is very wrong. The __version__ is generated by tools/generate_torch_version.py, which will either read the version from version.txt
pytorch/tools/generate_torch_version.py
Line 16 in c9ccb85
or from the PYTORCH_BUILD_VERSION environment variable.
There was a problem hiding this comment.
Ok! Thanks for the details.
soulitzer
added
the
triaged
albanD
approved these changes
Feb 14, 2022
| @@ -326,14 +326,11 @@ | |||
| # Customized html_title here. | |||
| # Default is " ".join(project, release, "documentation") if not set | |||
| if RELEASE: | |||
| # remove hash (start with 'a') from version number if any | |||
| version_end = torch_version.find('a') | |||
| if version_end == -1: | |||
There was a problem hiding this comment.
Ok! Thanks for the details.
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 14, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: #72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1
|
Hey @mattip. |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 15, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 15, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 15, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 16, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 16, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 20, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 21, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pytorch/pytorch.github.io#929
The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using
'.'.join(torch_version.split('.')[:2])since we no longer care about trimming off the HASH: it automatically gets removed.@holly1238, @brianjo