RC Docs Build includes the z version in the UI and title #929
Comments
|
I think this is due to the |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this issue
Feb 14, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: #72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 15, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 15, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 15, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 16, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 16, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 17, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 20, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 20, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 20, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this issue
Feb 21, 2022
Summary: Fixes pytorch/pytorch.github.io#929 The pytorch doc team would like to move to only major.minor documentation at https://pytorch.org/docs/versions.html, not major.minor.patch. This has been done in the CI scripts, but the generated documentation still has the patch version. Remove it when building RELEASE documentation. This allows simplifying the logic, using `'.'.join(torch_version.split('.')[:2])` since we no longer care about trimming off the HASH: it automatically gets removed. holly1238, brianjo Pull Request resolved: pytorch/pytorch#72706 Reviewed By: samdow Differential Revision: D34215815 Pulled By: albanD fbshipit-source-id: 8437036cc6636674d9ab8b1666f37b561d0527e1 (cherry picked from commit d8caf988f958656f357a497372a782ff69829f9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📚 Documentation
Our 1.11 RC docs build is going to the correct folder /docs/1.11/ but the version number in the UI and the title still includes .0 at the end. For 1.11, we'll not be specifying the semver patch version number in the docs. @mattip could you take a look at the build script and make any required changes?
Here's the RC 2 output: https://pytorch.org/docs/1.11/
Thanks!
cc: @holly1238 @malfet
The text was updated successfully, but these errors were encountered: