TrainsLogger -> ClearMLLogger #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydcjeff
commented
Jan 16, 2021
|
@ydcjeff thank you very much for this huge work. Although I need some time to review it... I do it as soon as possible !! |
You can take time to review it. Since most of the changes are changing |
vfdev-5
reviewed
Jan 16, 2021
sdesrozis
reviewed
Jan 17, 2021
sdesrozis
approved these changes
Jan 18, 2021
vfdev-5
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1553
Description: Renamed
TrainsLoggertoClearMLLoggerin all files found. Let me know if I miss something.Check list:
https://deploy-preview-1557--pytorch-ignite-preview.netlify.app/contrib/handlers.html#clearml-logger
https://deploy-preview-1557--pytorch-ignite-preview.netlify.app/contrib/engines.html#ignite.contrib.engines.common.setup_trains_logging