Skip to content

Fix semver comparison logic #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fparisio wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix semver comparison logic #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee87c5b
bug: fix semver comparison logic using packaging.version.Version
fparisio Dec 2, 2025
b5e7563
fix: add packaging to requirements
fparisio Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
torch
numpy
packaging
6 changes: 2 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import glob

from setuptools import find_packages, setup
from packaging.version import Version

from torch.utils.cpp_extension import (
CppExtension,
Expand All @@ -18,10 +19,7 @@

library_name = "extension_cpp"

if torch.__version__ >= "2.6.0":
py_limited_api = True
else:
py_limited_api = False
py_limited_api = Version(torch.__version__) >= Version("2.6.0")


def get_extensions():
Expand Down