Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Insights fixes #95

Merged
merged 4 commits into from
Oct 9, 2019
Merged

Small Insights fixes #95

merged 4 commits into from
Oct 9, 2019

Conversation

edward-io
Copy link
Contributor

@edward-io edward-io commented Oct 9, 2019

  • Import directly from captum.insights instead of captum.insights.api
  • Change default step size from 50 to 20
  • Rename Data to Batch to be more descriptive
  • Hide web server startup messages
  • Fix bug in deleting filter class tags
  • Fix up Captum Insights notebook, don't render the IFrame because it shows up on the website (thanks @caraya10 for pointing this out)

@edward-io edward-io requested review from NarineK, orionr and vivekmig and removed request for NarineK October 9, 2019 05:43
Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@orionr
Copy link
Contributor

orionr commented Oct 9, 2019

And make sure tests pass before landing (y)

@edward-io edward-io merged commit f6283d0 into pytorch:master Oct 9, 2019
@edward-io edward-io mentioned this pull request Oct 9, 2019
NarineK pushed a commit to NarineK/captum-1 that referenced this pull request Nov 19, 2020
* Import directly from `captum.insights` instead of `captum.insights.api`
* Change default step size from 50 to 20
* Rename `Data` to `Batch` to be more descriptive
* Hide web server startup messages
* Fix bug in deleting filter class tags
* Fix up Captum Insights notebook, don't render the IFrame because it shows up on the website (thanks @caraya10 for pointing this out)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants