Optimize Bert_SQUAD_Interpret #672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NarineK
commented
May 25, 2021
scripts/install_via_conda.sh
Outdated
| @@ -40,7 +40,7 @@ conda install -y -c conda-forge black matplotlib pytest-cov sphinx-autodoc-typeh | |||
| # install node/yarn for insights build | |||
| conda install -y -c conda-forge yarn | |||
| # nodejs should be last, otherwise other conda packages will downgrade node | |||
| conda update -y --no-channel-priority -c conda-forge nodejs | |||
| conda install -y --no-channel-priority -c conda-forge nodejs=13 | |||
There was a problem hiding this comment.
@vivekmig, @edward-io , this fixes the issue with the nodejs version. There might be better fixes but this fixed it for now.
Issue: #669
There was a problem hiding this comment.
Can we peg this to nodejs=14? According to https://nodejs.org/en/about/releases/ NodeJS 14 will be supported until 2022.
There was a problem hiding this comment.
Thank you, @edward-io! Created a separate PR (#675) so that we so that we don't have to wait Bert tutorial to be reviewed.
edward-io
approved these changes
May 25, 2021
Closed
vivekmig
approved these changes
Jun 21, 2021
tutorials/Bert_SQUAD_Interpret.ipynb
Outdated
| " input_embeddings = interpretable_embedding.indices_to_embeddings(input_ids, token_type_ids=token_type_ids, position_ids=position_ids)\n", | ||
| " ref_input_embeddings = interpretable_embedding.indices_to_embeddings(ref_input_ids, token_type_ids=token_type_ids, position_ids=position_ids)\n", | ||
| " input_embeddings = model.bert.embeddings(input_ids, token_type_ids=token_type_ids, position_ids=position_ids)\n", | ||
| " #interpretable_embedding.indices_to_embeddings(input_ids, token_type_ids=token_type_ids, position_ids=position_ids)\n", |
There was a problem hiding this comment.
nit: Should these commented out lines be removed?
NarineK
force-pushed
the
narine/fix_bert_squad_tutorial
branch
from
8889939 to
3d767bd
Compare
|
@NarineK has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes Bert_SQUAD_Interpret tutorial by:
configure_interpretable_layerby using forward function with theinputs_embedsargument.Addresses the improvements discussed in: #624