disable js map files to reduce package size #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edward-io
commented
Dec 11, 2020
edward-io
commented
- Clean up some JS warnings
- remove unpkg
- switch to plotlyjs-basic-dist-min
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
NarineK
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Thank you, @edward-io ! It looks like internal tests are failing. Do you mind investigating it ?
edward-io
force-pushed
the
replace-plotlyjs
branch
from
511c6fa to
69ae4ce
Compare
edward-io
force-pushed
the
replace-plotlyjs
branch
from
69ae4ce to
7aff065
Compare
There was a problem hiding this comment.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@edward-io merged this pull request in 485bbbb. |
vivekmig
pushed a commit
that referenced
this pull request
Jan 21, 2021
Summary: - Clean up some JS warnings - remove unpkg - switch to plotlyjs-basic-dist-min Pull Request resolved: #556 Reviewed By: NarineK Differential Revision: D25506078 Pulled By: edward-io fbshipit-source-id: f133975579c1ab3376f243499aca6520aafbb568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.