-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorials and update small Insights style changes #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good. I only looked into the notebooks.
"**Note:** Before running this tutorial, please install the torchvision, and matplotlib packages." | ||
"Then we use attribution algorithms such as `IntegratedGradients`, `Saliency`, `DeepLift` and `NoiseTunnel` to attribute the label of the image to the input pixels and visualize it.\n", | ||
" \n", | ||
" **Note:** Before running this tutorial, please install the torchvision, and matplotlib packages." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these intended changes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was automatically done by the notebook.
@@ -835,7 +835,7 @@ | |||
"name": "python", | |||
"nbconvert_exporter": "python", | |||
"pygments_lexer": "ipython3", | |||
"version": "3.7.4" | |||
"version": "3.7.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like python version changed. Here. We should probably agree on one and use that for all notebooks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the notebook should run the same for every Python version, I just had a different one than @vivekmig 's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@edward-io merged this pull request in 28b8925. |
Summary: Captum Insights: - Reduce padding around buttons for notebooks - Remove matplotlib grid for image features - Fix newline after every word in text features - Update screenshots Notebooks: - Add link to download models in notebook tutorials Pull Request resolved: pytorch#320 Reviewed By: orionr, J0Nreynolds Differential Revision: D20730447 Pulled By: edward-io fbshipit-source-id: ff5fbe575cf6cb6dbd554a45827d4c354d99e3d9
Captum Insights:
Notebooks: