create_baseline_stubs.py: Fix path separator on windows and ignore root /out#8653
Conversation
729e926 to
de3e9c8
Compare
de3e9c8 to
2cdb3ae
Compare
/outcreate_baseline_stubs.py: Fix path separator on windows and ignore root /out
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! I remember being bitten by the path-separator thing as well when I used create_baseline_stubs.py a while back on my Windows machine. Can't remember why I didn't file a PR to fix it.
hauntsaninja
left a comment
There was a problem hiding this comment.
Maybe we should do a replace in add_pyright_exclusion and let everything else do normal os.path stuff?
SGTM, though everything seems to work fine on my Windows machine either way :) |
Everything works in windows / powershell for me as well with either slashes (well except setting the environment variable MYPYPATH since the syntax is different in powershell, but that's unrelated to this work). So I don't mind either way. Only changing the slashes in |
Yes, let's do that |
On windows, the stub path is generated with a backslash, which of course is not valid when added to the json file.
create_baseline_stubs.pyalso creates aoutfolder at the root which was not gitignored.