Skip to content

Conversation

@arthurzenika
Copy link
Contributor

No description provided.

@arthurzenika arthurzenika changed the title [library/wsgiref] initial translation [library/wsgiref] initial partial translation Oct 9, 2019
arthurzenika and others added 5 commits October 9, 2019 23:47
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Copy link
Contributor Author

@arthurzenika arthurzenika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review

Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette PR.
Je t'ai noté quelques points qui méritent relecture.

Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette PR.
Je t'ai noté quelques points qui méritent relecture.

Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
@arthurzenika
Copy link
Contributor Author

@awecx énorme merci pour cette relecture et les suggestions de corrections !

Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
@JulienPalard
Copy link
Member

Il reste qq points de détails pour pouvoir merger, le « Renvoie une heuristique » et ligne 176—179.

@JulienPalard
Copy link
Member

Quelques souci d'orthographe et de wrapping selon travis:

library/wsgiref.po:46:utiliśee  # Compose key spotted :]
library/wsgiref.po:46:d'environment
library/wsgiref.po:63:wsgi.readthedocs.io
library/wsgiref.po:72:environments
library/wsgiref.po:168:wsgi

Co-Authored-By: Julien Palard <julien@palard.fr>
@christopheNan
Copy link
Contributor

Bonjour,
Avant de fusionner ta PR, il manque encore les fautes d'orthographe remontées par travis/pospell et que @JulienPalard t'a indiquées.

@Seluj78
Copy link
Collaborator

Seluj78 commented Nov 15, 2019

@arthurlogilab ping ! :) 🏓

@Seluj78 Seluj78 changed the title [library/wsgiref] initial partial translation [library/wsgiref.po] initial partial translation Nov 17, 2019
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On y est presque, il reste quelques erreurs remontées par pospell.
Je te les ai mises en suggestion , on pourra soumettre ta PR ensuite.
Merci

Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et quelques petites corrections suggérées par padpo.

padpo -p 900

https://github.com/vpoulailleau/padpo/

Co-Authored-By: Mathieu Dupuy <deronnax@users.noreply.github.com>
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Co-Authored-By: Vincent Poulailleau <vpoulailleau@gmail.com>
Co-Authored-By: Vincent Poulailleau <vpoulailleau@gmail.com>
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne sais pas écrire « environnement »...

arthurzenika and others added 2 commits November 21, 2019 14:37
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas de chance, ça a cassé le wrapping.
Relance powrap sur le code et repush, c'est presque bon.

Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'avais pas vu, tu n'as pas pris en compte la remarque de @deronnax :
« et toutes les autres variables WSGI définies dans »
Il te faut soit l'accepter (attention à la taille de la ligne), soit tu résous la conversation avec un commentaire pour expliquer ton choix.
On y est vraiment presque là.

Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deux remarques qui ont dû sauter entre deux commits.

@awecx
Copy link

awecx commented Dec 4, 2019

@arthurlogilab on y est presque. Tu peux voir mes remarques et celle de deronnax ?
Je merge la PR après.

arthurzenika and others added 2 commits December 6, 2019 09:19
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon pour merge en ce qui me concerne.

@awecx awecx merged commit d845e09 into python:3.8 Dec 7, 2019
@awecx
Copy link

awecx commented Dec 7, 2019

Merci pour cette PR !

awecx pushed a commit to awecx/python-docs-fr that referenced this pull request Dec 30, 2019
awecx added a commit that referenced this pull request Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants