Skip to content

Conversation

@kw-andy
Copy link
Contributor

@kw-andy kw-andy commented Apr 11, 2019

closes #668

@Seluj78 Seluj78 changed the title 668 cell po Working on cell.po Apr 11, 2019
@Seluj78 Seluj78 changed the title Working on cell.po Working on c-api/cell.po Apr 11, 2019
Seluj78 and others added 10 commits April 11, 2019 22:32
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Copy link
Collaborator

@Seluj78 Seluj78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check la CI pour powrap et quelques erreurs de pospell

@Seluj78 Seluj78 added the NEED REVIEWER This PR needs a reviewer :) label Apr 17, 2019
@Seluj78
Copy link
Collaborator

Seluj78 commented Apr 18, 2019

@kw-andy ping

Seluj78 and others added 8 commits April 18, 2019 14:31
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
Co-Authored-By: kw-andy <andy.h.kwok@gmail.com>
kw-andy and others added 4 commits May 9, 2019 12:15
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
@kw-andy
Copy link
Contributor Author

kw-andy commented May 9, 2019

@Seluj78 c'est ok pour moi

kw-andy and others added 3 commits May 9, 2019 12:17
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
@Seluj78 Seluj78 requested review from Seluj78 and christopheNan May 9, 2019 10:17
kw-andy and others added 3 commits May 9, 2019 14:03
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
@Seluj78
Copy link
Collaborator

Seluj78 commented May 9, 2019

il t'en manque un + powrap

kw-andy and others added 3 commits May 9, 2019 14:18
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
@kw-andy
Copy link
Contributor Author

kw-andy commented May 12, 2019

@Seluj78 & @christopheNan , le test via Travis est passé. C'est ok pour vous ?

@JulienPalard JulienPalard merged commit 3dc32e4 into python:3.7 May 12, 2019
@JulienPalard
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NEED REVIEWER This PR needs a reviewer :)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

je travaille sur c-api/cell.po

6 participants