Skip to content

[Skip Issue] Fix a possible decref of a borrowed reference in symtable.c #9786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Oct 11, 2018
Merged

[Skip Issue] Fix a possible decref of a borrowed reference in symtable.c #9786

serhiy-storchaka merged 1 commit into from
Oct 11, 2018

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Oct 10, 2018 •
edited
Loading

If PyObject_GetIter() fails in update_symbols(), name will be decrefed, but name is a borrowed reference at this point.

@ZackerySpytz ZackerySpytz changed the title [Skip Issue] Fix a possible decrerf of a borrowed reference in symtable.c [Skip Issue] Fix a possible decref of a borrowed reference in symtable.c Oct 10, 2018
@asvetlov
Copy link
Contributor

asvetlov commented Oct 10, 2018

If it is a fix for possible interpreter crash -- please create an issue.
The change is important enough to be tracked.

@serhiy-storchaka serhiy-storchaka merged commit fc439d2 into python:master Oct 11, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2018

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2018
@ZackerySpytz @miss-islington
Fix a possible decref of a borrowed reference in symtable.c. (pythonG…
3567ee9 
…H-9786)

(cherry picked from commit fc439d2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2018

GH-9799 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2018

GH-9800 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2018
@ZackerySpytz @miss-islington
Fix a possible decref of a borrowed reference in symtable.c. (pythonG…
cd39df7 
…H-9786)

(cherry picked from commit fc439d2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2018

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fc439d20de32b0ebccca79a96e31f83b85ec4eaf 2.7

@serhiy-storchaka serhiy-storchaka removed their assignment Oct 11, 2018
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Oct 11, 2018
miss-islington added a commit that referenced this pull request Oct 11, 2018
@miss-islington @ZackerySpytz
Fix a possible decref of a borrowed reference in symtable.c. (GH-9786)
1c2cb51 
(cherry picked from commit fc439d2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Oct 11, 2018
@miss-islington @ZackerySpytz
Fix a possible decref of a borrowed reference in symtable.c. (GH-9786)
1a23abe 
(cherry picked from commit fc439d2)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

+1 more reviewer

@4383 4383 4383 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZackerySpytz @asvetlov @miss-islington @bedevere-bot @4383 @serhiy-storchaka @the-knights-who-say-ni