bpo-33361: Fix bug with seeking in StreamRecoders #8278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libcthorne
reviewed
Jul 17, 2018
Lib/codecs.py
Outdated
| @@ -847,6 +847,12 @@ def reset(self): | |||
| self.reader.reset() | |||
| self.writer.reset() | |||
|
|
|||
| def seek(self, offset, whence=0): | |||
| # Seeks must be propogated to both the readers and writers | |||
There was a problem hiding this comment.
Minor nitpick but there is a typo in the comment ("propogated" -> "propagated")
BoboTiG
approved these changes
Aug 25, 2018
berkerpeksag
approved these changes
May 31, 2019
|
Thanks @ammaraskar for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 31, 2019
(cherry picked from commit a6ec1ce) Co-authored-by: Ammar Askar <ammar_askar@hotmail.com>
|
GH-13708 is a backport of this pull request to the 3.7 branch. |
berkerpeksag
pushed a commit
that referenced
this pull request
May 31, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is a basic example from the bpo ticket, more can be added if necessary.
https://bugs.python.org/issue33361