bpo-32267: Fix parsing tz offsets microseconds shorter than 6 #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the remainder is directly parsed as an int, strings like .600 will be parsed as 600 microsecond rather than miliseconds.
mariocj89
changed the title
mariocj89
changed the title
pganssle
reviewed
Dec 13, 2017
| gmtoff_fraction = int(z[8:] or 0) | ||
| gmtoff_remainder = z[8:] | ||
| # Pad to always return microseconds. | ||
| gmtoff_remainder_padding = "0" * (6 - len(gmtoff_remainder)) |
There was a problem hiding this comment.
I did a microbenchmark for this vs. multiplying by 10**(6-len(gmtoff_remainder)) and it seems like your version is either faster or the same speed. Maybe that's why you chose this method, but I thought I'd chime in since I went through the trouble to check it.
|
@abalkin sorry to mention you but without this change the previous PR change is buggy. |
|
FWIW this patch looks good to me. |
abalkin
approved these changes
Jan 9, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the remainder is directly parsed as an int, strings like .600 will be parsed as 600 microsecond rather than milliseconds.
I've added no news entries as it was included in #4015 and I think it has not been released yet. Please let me know if one should be added.
https://bugs.python.org/issue32267