Adapt sqlite3.Connection.open_blob() to AC

Modules/_sqlite/clinic/connection.c.h

@@ -140,6 +140,101 @@ pysqlite_connection_cursor(pysqlite_Connection *self, PyObject *const *args, Py_
     return return_value;
 }
 
+PyDoc_STRVAR(pysqlite_connection_open_blob__doc__,
+"open_blob($self, /, table, column, row, *, readonly=False,\n"
+"          dbname=\'main\')\n"
+"--\n"
+"\n"
+"Return a blob object. Non-standard.");
+
+#define PYSQLITE_CONNECTION_OPEN_BLOB_METHODDEF    \
+    {"open_blob", (PyCFunction)(void(*)(void))pysqlite_connection_open_blob, METH_FASTCALL|METH_KEYWORDS, pysqlite_connection_open_blob__doc__},
+
+static PyObject *
+pysqlite_connection_open_blob_impl(pysqlite_Connection *self,
+                                   const char *table, const char *column,
+                                   int row, int readonly, const char *dbname);
+
+static PyObject *
+pysqlite_connection_open_blob(pysqlite_Connection *self, PyObject *const *args, Py_ssize_t nargs, PyObject *kwnames)
+{
+    PyObject *return_value = NULL;
+    static const char * const _keywords[] = {"table", "column", "row", "readonly", "dbname", NULL};
+    static _PyArg_Parser _parser = {NULL, _keywords, "open_blob", 0};
+    PyObject *argsbuf[5];
+    Py_ssize_t noptargs = nargs + (kwnames ? PyTuple_GET_SIZE(kwnames) : 0) - 3;
+    const char *table;
+    const char *column;
+    int row;
+    int readonly = 0;
+    const char *dbname = "main";
+
+    args = _PyArg_UnpackKeywords(args, nargs, NULL, kwnames, &_parser, 3, 3, 0, argsbuf);
+    if (!args) {
+        goto exit;
+    }
+    if (!PyUnicode_Check(args[0])) {
+        _PyArg_BadArgument("open_blob", "argument 'table'", "str", args[0]);
+        goto exit;
+    }
+    Py_ssize_t table_length;
+    table = PyUnicode_AsUTF8AndSize(args[0], &table_length);
+    if (table == NULL) {
+        goto exit;
+    }
+    if (strlen(table) != (size_t)table_length) {
+        PyErr_SetString(PyExc_ValueError, "embedded null character");
+        goto exit;
+    }
+    if (!PyUnicode_Check(args[1])) {
+        _PyArg_BadArgument("open_blob", "argument 'column'", "str", args[1]);
+        goto exit;
+    }
+    Py_ssize_t column_length;
+    column = PyUnicode_AsUTF8AndSize(args[1], &column_length);
+    if (column == NULL) {
+        goto exit;
+    }
+    if (strlen(column) != (size_t)column_length) {
+        PyErr_SetString(PyExc_ValueError, "embedded null character");
+        goto exit;
+    }
+    row = _PyLong_AsInt(args[2]);
+    if (row == -1 && PyErr_Occurred()) {
+        goto exit;
+    }
+    if (!noptargs) {
+        goto skip_optional_kwonly;
+    }
+    if (args[3]) {
+        readonly = _PyLong_AsInt(args[3]);
+        if (readonly == -1 && PyErr_Occurred()) {
+            goto exit;
+        }
+        if (!--noptargs) {
+            goto skip_optional_kwonly;
+        }
+    }
+    if (!PyUnicode_Check(args[4])) {
+        _PyArg_BadArgument("open_blob", "argument 'dbname'", "str", args[4]);
+        goto exit;
+    }
+    Py_ssize_t dbname_length;
+    dbname = PyUnicode_AsUTF8AndSize(args[4], &dbname_length);
+    if (dbname == NULL) {
+        goto exit;
+    }
+    if (strlen(dbname) != (size_t)dbname_length) {
+        PyErr_SetString(PyExc_ValueError, "embedded null character");
+        goto exit;
+    }
+skip_optional_kwonly:
+    return_value = pysqlite_connection_open_blob_impl(self, table, column, row, readonly, dbname);
+
+exit:
+    return return_value;
+}
+
 PyDoc_STRVAR(pysqlite_connection_close__doc__,
 "close($self, /)\n"
 "--\n"
@@ -816,4 +911,4 @@ pysqlite_connection_exit(pysqlite_Connection *self, PyObject *const *args, Py_ss
 #ifndef PYSQLITE_CONNECTION_LOAD_EXTENSION_METHODDEF
     #define PYSQLITE_CONNECTION_LOAD_EXTENSION_METHODDEF
 #endif /* !defined(PYSQLITE_CONNECTION_LOAD_EXTENSION_METHODDEF) */
-/*[clinic end generated code: output=9c0dfc6c1ebf9039 input=a9049054013a1b77]*/
+/*[clinic end generated code: output=2c37726d47594c3d input=a9049054013a1b77]*/

Modules/_sqlite/connection.c

@@ -374,26 +374,30 @@ pysqlite_connection_cursor_impl(pysqlite_Connection *self, PyObject *factory)
     return cursor;
 }
 
-PyObject* pysqlite_connection_blob(pysqlite_Connection *self, PyObject *args,
-                                   PyObject *kwargs)
+/*[clinic input]
+_sqlite3.Connection.open_blob as pysqlite_connection_open_blob
+
+    table: str
+    column: str
+    row: int
+    *
+    readonly: bool(accept={int}) = False
+    dbname: str = "main"
+
+Return a blob object. Non-standard.
+[clinic start generated code]*/
+
+static PyObject *
+pysqlite_connection_open_blob_impl(pysqlite_Connection *self,
+                                   const char *table, const char *column,
+                                   int row, int readonly, const char *dbname)
+/*[clinic end generated code: output=54dfadc6f1283245 input=38c93f0f7d73a1ef]*/
 {
-    static char *kwlist[] = {"table", "column", "row", "readonly",
-                             "dbname", NULL};
     int rc;
-    const char *dbname = "main", *table, *column;
-    long long row;
-    int readonly = 0;
     sqlite3_blob *blob;
     pysqlite_Blob *pyblob = NULL;
     PyObject *weakref;
 
-
-    if (!PyArg_ParseTupleAndKeywords(args, kwargs, "ssL|$ps", kwlist,
-                                     &table, &column, &row, &readonly,
-                                     &dbname)) {
-        return NULL;
-    }
-
     Py_BEGIN_ALLOW_THREADS
     rc = sqlite3_blob_open(self->db, dbname, table, column, row,
                            !readonly, &blob);
@@ -1957,8 +1961,6 @@ static PyGetSetDef connection_getset[] = {
 };
 
 static PyMethodDef connection_methods[] = {
-    {"open_blob", (PyCFunction)pysqlite_connection_blob, METH_VARARGS|METH_KEYWORDS,
-        PyDoc_STR("return a blob object")},
     PYSQLITE_CONNECTION_BACKUP_METHODDEF
     PYSQLITE_CONNECTION_CLOSE_METHODDEF
     PYSQLITE_CONNECTION_COMMIT_METHODDEF
@@ -1975,6 +1977,7 @@ static PyMethodDef connection_methods[] = {
     PYSQLITE_CONNECTION_INTERRUPT_METHODDEF
     PYSQLITE_CONNECTION_ITERDUMP_METHODDEF
     PYSQLITE_CONNECTION_LOAD_EXTENSION_METHODDEF
+    PYSQLITE_CONNECTION_OPEN_BLOB_METHODDEF
     PYSQLITE_CONNECTION_ROLLBACK_METHODDEF
     PYSQLITE_CONNECTION_SET_AUTHORIZER_METHODDEF
     PYSQLITE_CONNECTION_SET_PROGRESS_HANDLER_METHODDEF