Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Include typing prefix for __qualname__ attr"
This reverts commit d683ee3.
  • Loading branch information
uriyyo committed Jul 19, 2021
commit 5440355569a1df5af4cb38bac12a062e8c4b47c4
2 changes: 1 addition & 1 deletion Lib/test/test_typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -4543,7 +4543,7 @@ def test_special_attrs(self):

for cls in cls_to_check:
self.assertEqual(cls.__name__, cls._name)
self.assertEqual(cls.__qualname__, f'typing.{cls._name}')
self.assertEqual(cls.__qualname__, cls._name)
self.assertEqual(cls.__module__, 'typing')

class AllTests(BaseTestCase):
Expand Down
4 changes: 1 addition & 3 deletions Lib/typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -935,10 +935,8 @@ def __mro_entries__(self, bases):
return tuple(res)

def __getattr__(self, attr):
if attr == '__name__':
if attr in {'__name__', '__qualname__'}:
return self._name
if attr == '__qualname__':
return f'typing.{self._name}'

# We are careful for copy and pickle.
# Also for simplicity we just don't relay all dunder names
Expand Down