Skip to content

[3.8] Improve readability of formataddr docstring (GH-20963) #20977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

[3.8] Improve readability of formataddr docstring (GH-20963) #20977

merged 1 commit into from
Jun 19, 2020

Conversation

miss-islington
Copy link
Contributor

For me as a non native English speaker, the sentence with its embedded clause was very hard to understand.

modified: Lib/email/utils.py

Automerge-Triggered-By: @csabella
(cherry picked from commit 66a65ba)

Co-authored-by: Jürgen Gmach juergen.gmach@googlemail.com

@jugmac00 @miss-islington
Improve readability of formataddr docstring (pythonGH-20963)
401d223 
For me as a non native English speaker, the sentence with its embedded clause was very hard to understand.

modified:   Lib/email/utils.py

Automerge-Triggered-By: @csabella
(cherry picked from commit 66a65ba)

Co-authored-by: Jürgen Gmach <juergen.gmach@googlemail.com>
@miss-islington miss-islington requested a review from a team as a code owner June 19, 2020 11:57
@bedevere-bot bedevere-bot mentioned this pull request Jun 19, 2020
Merged
csabella
csabella approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@miss-islington
Copy link
Contributor Author

@jugmac00: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 4dd10ed into python:3.8 Jun 19, 2020
@miss-islington miss-islington deleted the backport-66a65ba-3.8 branch June 19, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @csabella @the-knights-who-say-ni @bedevere-bot @jugmac00